github-actions[bot] commented on code in PR #32299:
URL: https://github.com/apache/doris/pull/32299#discussion_r1528232053
##########
be/src/olap/wal/wal_writer.cpp:
##########
@@ -90,7 +90,7 @@ Status WalWriter::append_blocks(const PBlockArray& blocks) {
return Status::OK();
}
-Status WalWriter::append_header(uint32_t version, std::string col_ids) {
+Status WalWriter::append_header(std::string col_ids) {
Review Comment:
warning: method 'append_header' can be made const
[readability-make-member-function-const]
```suggestion
Status WalWriter::append_header(std::string col_ids) const {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
