github-actions[bot] commented on code in PR #32405:
URL: https://github.com/apache/doris/pull/32405#discussion_r1528227202
##########
be/src/olap/base_tablet.cpp:
##########
@@ -1430,4 +1430,19 @@ Status
BaseTablet::update_delete_bitmap_without_lock(const BaseTabletSPtr& self,
return Status::OK();
}
+RowsetSharedPtr BaseTablet::get_rowset(const RowsetId& rowset_id) {
Review Comment:
warning: method 'get_rowset' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/base_tablet.h:238:
```diff
- RowsetSharedPtr get_rowset(const RowsetId& rowset_id);
+ static RowsetSharedPtr get_rowset(const RowsetId& rowset_id);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
