liaoxin01 commented on code in PR #32098:
URL: https://github.com/apache/doris/pull/32098#discussion_r1528202498
##########
fe/fe-core/src/main/java/org/apache/doris/load/routineload/KafkaRoutineLoadJob.java:
##########
@@ -93,6 +95,7 @@ public class KafkaRoutineLoadJob extends RoutineLoadJob {
// kafka properties ，property prefix will be mapped to kafka custom
parameters, which can be extended in the future
private Map<String, String> customProperties = Maps.newHashMap();
private Map<String, String> convertedCustomProperties = Maps.newHashMap();
+ private Map<String, Map<String, String>> convertedRackCustomProperties =
Maps.newHashMap();
Review Comment:
Adding the property convertedRackCustomimProperties makes the code look
complex. I think you can set this parameter in `createRoutineLoadTask`
function, just set add the parameter to `tKafkaLoadInfo.Properties`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
