yiguolei commented on code in PR #32346:
URL: https://github.com/apache/doris/pull/32346#discussion_r1528027286
##########
be/src/pipeline/pipeline_fragment_context.h:
##########
@@ -51,14 +51,17 @@ namespace pipeline {
class PipelineFragmentContext : public TaskExecutionContext {
public:
+ ENABLE_FACTORY_CREATOR(PipelineFragmentContext);
// Callback to report execution status of plan fragment.
// 'profile' is the cumulative profile, 'done' indicates whether the
execution
// is done or still continuing.
// Note: this does not take a const RuntimeProfile&, because it might need
to call
// functions like PrettyPrint() or to_thrift(), neither of which is const
// because they take locks.
+ static std::shared_ptr<PipelineFragmentContext> fake_context;
Review Comment:
Do not use global static variable, we do not know when it is deconstruted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
