zuochunwei opened a new pull request #7024:
URL: https://github.com/apache/incubator-doris/pull/7024


   old version:
   NodeChannel::_node_info is a pointer member data, this member pointer is set 
by _parent->_nodes_info->find_node in the function NodeChannel::init(), 
_parent->_nodes_info is managed by object_pool, the object_pool‘ lifetime is 
the same with PlanFragmentExecutor.
   
   but _node_info will be used in _add_batch_closure' success handler, it's a 
async callback, in this callback, PlanFragmentExecutor created for other RPC 
may be destroy for some reasons, such as timeout or canceled, so continue use 
_node_info is wrong.
   
   refactor: use NodeInfo _node_info replace NodeInfo *_node_info, just copy 
NodeInfo in init function


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to