morningman commented on a change in pull request #6979:
URL: https://github.com/apache/incubator-doris/pull/6979#discussion_r742512082
##########
File path: be/src/runtime/mem_tracker.h
##########
@@ -170,6 +173,12 @@ class MemTracker : public
std::enable_shared_from_this<MemTracker> {
Release(-bytes);
return true;
}
+ if (MemInfo::current_mem() + bytes >= MemInfo::mem_limit()) {
+ VLOG_NOTICE << "TryConsume failed, bytes=" << bytes
+ << " process whole consumption=" <<
MemInfo::current_mem()
+ << " mem limit=" << MemInfo::mem_limit();
Review comment:
We should find a way to make the error more obvious and give a feasible
troubleshooting method or handling advice.
Otherwise, this change will simply block the error, but it will not bring
more help. (We can't even know if this error has occurred)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
