morrySnow commented on code in PR #32244: URL: https://github.com/apache/doris/pull/32244#discussion_r1525694019
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/SumLiteralRewrite.java: ########## @@ -0,0 +1,157 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.nereids.rules.rewrite; + +import org.apache.doris.common.Pair; +import org.apache.doris.nereids.rules.Rule; +import org.apache.doris.nereids.rules.RuleType; +import org.apache.doris.nereids.trees.expressions.Add; +import org.apache.doris.nereids.trees.expressions.Alias; +import org.apache.doris.nereids.trees.expressions.BinaryArithmetic; +import org.apache.doris.nereids.trees.expressions.Expression; +import org.apache.doris.nereids.trees.expressions.Multiply; +import org.apache.doris.nereids.trees.expressions.NamedExpression; +import org.apache.doris.nereids.trees.expressions.Slot; +import org.apache.doris.nereids.trees.expressions.Subtract; +import org.apache.doris.nereids.trees.expressions.functions.agg.AggregateFunction; +import org.apache.doris.nereids.trees.expressions.functions.agg.Count; +import org.apache.doris.nereids.trees.expressions.functions.agg.Sum; +import org.apache.doris.nereids.trees.expressions.literal.Literal; +import org.apache.doris.nereids.trees.plans.Plan; +import org.apache.doris.nereids.trees.plans.logical.LogicalAggregate; +import org.apache.doris.nereids.trees.plans.logical.LogicalProject; + +import com.google.common.collect.ImmutableList; +import org.apache.thrift.annotation.Nullable; + +import java.util.HashMap; +import java.util.List; +import java.util.Map; +import java.util.Objects; +import java.util.Set; +import java.util.stream.Collectors; + +/** + * sum(expr +/- literal) ==> sum(expr) +/- literal * count(expr) + */ +public class SumLiteralRewrite extends OneRewriteRuleFactory { + @Override + public Rule build() { + return logicalAggregate() + .whenNot(agg -> agg.getSourceRepeat().isPresent()) + .then(agg -> { + Map<NamedExpression, Pair<Expression, Literal>> funcMap = agg.getOutputs().stream() + .map(this::extractSumLiteral) + .filter(Objects::nonNull) + .collect(Collectors.toMap(item -> item.first, item -> item.second)); + if (funcMap.isEmpty()) { + return null; + } + return rewriteSumLiteral(agg, funcMap); + } + ).toRule(RuleType.COUNT_LITERAL_REWRITE); + } + + private Plan rewriteSumLiteral(LogicalAggregate<?> agg, Map<NamedExpression, Pair<Expression, Literal>> funcMap) { + Set<NamedExpression> newAggOutput = agg.getOutputExpressions().stream() + .filter(expr -> !funcMap.containsKey(expr)) + .collect(Collectors.toSet()); + Map<Expression, Slot> exprToSum = new HashMap<>(); + Map<Expression, Slot> exprToCount = new HashMap<>(); + Map<AggregateFunction, NamedExpression> existedAggFunc = agg.getOutputExpressions().stream() + .filter(e -> e.children().size() == 1 && e.child(0) instanceof AggregateFunction) + .map(e -> Pair.of(e.child(0), e)) + .collect(Collectors.toMap(item -> (AggregateFunction) item.first, item -> item.second)); + funcMap.values().stream() + .map(expressionLiteralPair -> expressionLiteralPair.first) + .distinct() + .forEach(e -> { + NamedExpression namedSum = constructSum(e, existedAggFunc); + NamedExpression namedCount = constructCount(e, existedAggFunc); + exprToSum.put(e, namedSum.toSlot()); + exprToCount.put(e, namedCount.toSlot()); + newAggOutput.add(namedSum); + newAggOutput.add(namedCount); + }); + LogicalAggregate<?> newAgg = agg.withAggOutput(ImmutableList.copyOf(newAggOutput)); + List<NamedExpression> newProjects = agg.getOutputExpressions().stream() + .map(namedExpr -> { + if (!funcMap.containsKey(namedExpr)) { + return namedExpr.toSlot(); + } + Expression originExpr = funcMap.get(namedExpr).first; + Literal literal = funcMap.get(namedExpr).second; + if (namedExpr.child(0).child(0) instanceof Add) { + Expression newExpr = new Add(exprToSum.get(originExpr), + new Multiply(literal, exprToCount.get(originExpr))); + return new Alias(namedExpr.getExprId(), newExpr, namedExpr.getName()); + } else { + Expression newExpr = new Subtract(exprToSum.get(originExpr), + new Multiply(literal, exprToCount.get(originExpr))); + return new Alias(namedExpr.getExprId(), newExpr, namedExpr.getName()); + } + }).collect(Collectors.toList()); + + return new LogicalProject<>(newProjects, newAgg); + } + + private NamedExpression constructSum(Expression child, Map<AggregateFunction, NamedExpression> existedAggFunc) { + Sum sum = new Sum(child); + NamedExpression namedSum; + if (existedAggFunc.containsKey(sum)) { + namedSum = existedAggFunc.get(sum); + } else { + namedSum = new Alias(sum); + } + return namedSum; + } + + private NamedExpression constructCount(Expression child, Map<AggregateFunction, NamedExpression> existedAggFunc) { + Count count = new Count(child); + NamedExpression namedCount; + if (existedAggFunc.containsKey(count)) { + namedCount = existedAggFunc.get(count); + } else { + namedCount = new Alias(count); + } + return namedCount; + } + + private @Nullable Pair<NamedExpression, Pair<Expression, Literal>> extractSumLiteral( + NamedExpression namedExpression) { + if (namedExpression.children().size() != 1) { + return null; + } + Expression func = namedExpression.child(0); + if (!(func instanceof Sum)) { + return null; + } + Expression child = func.child(0); + if (!(child instanceof Add) && !(child instanceof Subtract)) { + return null; + } + + Expression left = ((BinaryArithmetic) child).left(); + Expression right = ((BinaryArithmetic) child).right(); + if (!right.isLiteral() && !(left instanceof Slot)) { + // right now, only support slot +/- literal + return null; + } Review Comment: please test decimal type carefully to ensure we can always get correct precision and scale -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
