xiaokang commented on code in PR #32232:
URL: https://github.com/apache/doris/pull/32232#discussion_r1524911913
##########
be/src/olap/inverted_index_parser.h:
##########
@@ -49,6 +49,9 @@ struct InvertedIndexCtx {
using InvertedIndexCtxSPtr = std::shared_ptr<InvertedIndexCtx>;
+const std::string INVERTED_INDEX_PARSER_YES = "true";
Review Comment:
TRUE/FALSE
##########
be/src/olap/tablet_schema.cpp:
##########
@@ -616,6 +616,12 @@ void TabletIndex::to_schema_pb(TabletIndexPB* index) const
{
for (const auto& kv : _properties) {
(*index->mutable_properties())[kv.first] = kv.second;
}
+
+ // lowercase by default
+ if (!_properties.contains(INVERTED_INDEX_PARSER_LOWERCASE_KEY)) {
Review Comment:
It may be better to set default value true on fe.
##########
be/src/olap/rowset/segment_v2/segment_iterator.cpp:
##########
@@ -1234,7 +1234,7 @@ Status SegmentIterator::_init_inverted_index_iterators() {
if (_inverted_index_iterators[cid] == nullptr) {
RETURN_IF_ERROR(_segment->new_inverted_index_iterator(
_opts.tablet_schema->column(cid),
- _opts.tablet_schema->get_inverted_index(unique_id), _opts,
+ _segment->_tablet_schema->get_inverted_index(unique_id),
_opts,
Review Comment:
add comment to explain why use segment tablet_schema
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
