github-actions[bot] commented on code in PR #32210:
URL: https://github.com/apache/doris/pull/32210#discussion_r1524750213
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -747,9 +749,15 @@
// used by shuffle runtime filter
// assign this filter by protobuf
- Status assign(const PMinMaxFilter* minmax_filter) {
+ Status assign(const PMinMaxFilter* minmax_filter, bool contain_null) {
Review Comment:
warning: function 'assign' exceeds recommended size/complexity thresholds
[readability-function-size]
```cpp
Status assign(const PMinMaxFilter* minmax_filter, bool contain_null) {
^
```
<details>
<summary>Additional context</summary>
**be/src/exprs/runtime_filter.cpp:751:** 134 lines including whitespace and
comments (threshold 80)
```cpp
Status assign(const PMinMaxFilter* minmax_filter, bool contain_null) {
^
```
</details>
##########
be/src/exprs/runtime_filter.cpp:
##########
@@ -747,9 +749,15 @@ class RuntimePredicateWrapper {
// used by shuffle runtime filter
// assign this filter by protobuf
- Status assign(const PMinMaxFilter* minmax_filter) {
+ Status assign(const PMinMaxFilter* minmax_filter, bool contain_null) {
Review Comment:
warning: method 'assign' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status assign(const PMinMaxFilter* minmax_filter, bool
contain_null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
