morrySnow commented on code in PR #32200: URL: https://github.com/apache/doris/pull/32200#discussion_r1524331219
########## fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java: ########## @@ -1486,6 +1488,9 @@ public void setEnableLeftZigZag(boolean enableLeftZigZag) { @VariableMgr.VarAttr(name = ENABLE_UNIQUE_KEY_PARTIAL_UPDATE, needForward = true) public boolean enableUniqueKeyPartialUpdate = false; + @VariableMgr.VarAttr(name = ENABLE_AGG_KEY_PARTIAL_UPDATE, needForward = true) + public boolean enableAggregateKeyPartialUpdate = false; Review Comment: what's different between `enableUniqueKeyPartialUpdate` and `enableAggregateKeyPartialUpdate`? why not use one variable to control them? In `LogicalPlanBuilder` and `BindSink`, we cannot distinguish them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org