yiguolei commented on code in PR #32159:
URL: https://github.com/apache/doris/pull/32159#discussion_r1522521491


##########
be/src/runtime/runtime_predicate.h:
##########
@@ -46,13 +46,19 @@ class RuntimePredicate {
 
     Status init(PrimitiveType type, bool nulls_first, bool is_asc, const 
std::string& col_name);
 
-    bool inited() {
+    bool inited() const {
         std::unique_lock<std::shared_mutex> wlock(_rwlock);
         return _inited;
     }
 
+    bool need_update() const {
+        std::unique_lock<std::shared_mutex> wlock(_rwlock);

Review Comment:
   why name wlock? actuall it is a readlock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to