JNSimba commented on code in PR #341:
URL:
https://github.com/apache/doris-flink-connector/pull/341#discussion_r1521148907
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/deserialization/converter/DorisRowConverter.java:
##########
@@ -195,9 +196,11 @@ public DeserializationConverter
createInternalConverter(LogicalType type) {
return val -> {
if (val instanceof LocalDateTime) {
return TimestampData.fromLocalDateTime((LocalDateTime)
val);
+ } else if (val instanceof Timestamp) {
+ return TimestampData.fromTimestamp((Timestamp) val);
} else {
throw new UnsupportedOperationException(
- "timestamp type must be
java.time.LocalDateTime, the actual type is: "
+ "timestamp type must be
java.time.LocalDateTime or java.time.Timestamp, the actual type is: "
Review Comment:
is java.sql.timestamp ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
