morningman commented on code in PR #31768:
URL: https://github.com/apache/doris/pull/31768#discussion_r1512288590
##########
gensrc/thrift/Descriptors.thrift:
##########
@@ -343,6 +343,12 @@ struct TMCTable {
8: optional string tunnel_url
}
+struct TTrinoConnectorTable {
+ 1: required string db_name
Review Comment:
use optional
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/Env.java:
##########
@@ -780,6 +795,31 @@ public static Env getCurrentEnv() {
}
}
+ private void initSpiEnvironment() {
Review Comment:
Can it be lazy init?
##########
fe/fe-common/src/main/java/org/apache/doris/common/Config.java:
##########
@@ -2516,6 +2516,10 @@ public class Config extends ConfigBase {
options = {"default", "ranger-doris"})
public static String access_controller_type = "default";
+ @ConfField(mutable = true, masterOnly = false, description = {"指定
trino-connector catalog 的插件默认加载路径",
+ "Specify the default plugins loading path for the trino-connector
catalog"})
+ public static String trino_connector_plugin_dir = EnvUtils.getDorisHome()
+ "/lib/connectors";
Review Comment:
```suggestion
public static String trino_connector_plugin_dir =
EnvUtils.getDorisHome() + "/connectors";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
