github-actions[bot] commented on code in PR #31741:
URL: https://github.com/apache/doris/pull/31741#discussion_r1510875372
##########
be/src/vec/exec/scan/new_jdbc_scan_node.h:
##########
@@ -45,6 +45,14 @@ class NewJdbcScanNode : public VScanNode {
protected:
Status _init_profile() override;
Status _init_scanners(std::list<VScannerSPtr>* scanners) override;
+ Status _process_conjuncts() override;
+
+private:
+ Status _process_rf_exprs();
+ Status _convert_rf_expr_to_sql_str(const vectorized::VExprSPtr& expr,
+ std::vector<std::string>& filters);
+ std::string _convert_value_data(PrimitiveType type, const void* value);
+ void _append_rf_string(std::string filter_str);
private:
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/vec/exec/scan/new_jdbc_scan_node.h:49:** previously declared here
```cpp
private:
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
