zclllyybb commented on code in PR #31434:
URL: https://github.com/apache/doris/pull/31434#discussion_r1506958770
##########
be/src/util/thrift_server.cpp:
##########
@@ -375,7 +375,7 @@ Status ThriftServer::start() {
new ThriftServer::ThriftServerEventProcessor(this));
_server->setServerEventHandler(event_processor);
- RETURN_IF_ERROR(event_processor->start_and_wait_for_server());
+ static_cast<void>(event_processor->start_and_wait_for_server());
Review Comment:
What's wrong before?
##########
be/src/util/thrift_server.cpp:
##########
@@ -375,7 +375,7 @@ Status ThriftServer::start() {
new ThriftServer::ThriftServerEventProcessor(this));
_server->setServerEventHandler(event_processor);
- RETURN_IF_ERROR(event_processor->start_and_wait_for_server());
+ static_cast<void>(event_processor->start_and_wait_for_server());
Review Comment:
We shouldn't change this. please explain this logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
