gavinchou commented on code in PR #31415:
URL: https://github.com/apache/doris/pull/31415#discussion_r1503735213
##########
cloud/src/meta-service/keys.cpp:
##########
@@ -115,11 +115,12 @@ static void encode_prefix(const T& t, std::string* key) {
RecycleIndexKeyInfo, RecyclePartKeyInfo, RecycleRowsetKeyInfo,
RecycleTxnKeyInfo, RecycleStageKeyInfo,
StatsTabletKeyInfo,
JobTabletKeyInfo, JobRecycleKeyInfo, RLJobProgressKeyInfo,
- CopyJobKeyInfo, CopyFileKeyInfo>);
+ CopyJobKeyInfo, CopyFileKeyInfo, StorageVaultKeyInfo>);
key->push_back(CLOUD_USER_KEY_SPACE01);
// Prefixes for key families
- if constexpr (std::is_same_v<T, InstanceKeyInfo>) {
+ if constexpr (std::is_same_v<T, InstanceKeyInfo>
+ || std::is_same_v<T, StorageVaultKeyInfo>) {
Review Comment:
StorageVaultKeyInfo is not int the family of InstanceKeyInfo.
it should be
0x01 "storage_vault" $instance_id $resource_id
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
