github-actions[bot] commented on code in PR #31434:
URL: https://github.com/apache/doris/pull/31434#discussion_r1502627295
##########
be/src/vec/functions/function_rpc.cpp:
##########
@@ -65,16 +66,17 @@ Status RPCFnImpl::vec_call(FunctionContext* context, Block&
block, const ColumnN
return Status::OK();
}
-void RPCFnImpl::_convert_block_to_proto(Block& block, const ColumnNumbers&
arguments,
- size_t input_rows_count,
PFunctionCallRequest* request) {
+Status RPCFnImpl::_convert_block_to_proto(Block& block, const ColumnNumbers&
arguments,
Review Comment:
warning: method '_convert_block_to_proto' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RPCFnImpl::_convert_block_to_proto(Block& block, const
ColumnNumbers& arguments,
```
##########
be/src/vec/functions/function_totype.h:
##########
@@ -18,6 +18,7 @@
#pragma once
#include <fmt/format.h>
Review Comment:
warning: 'fmt/format.h' file not found [clang-diagnostic-error]
```cpp
#include <fmt/format.h>
^
```
##########
be/src/vec/sink/autoinc_buffer.cpp:
##########
@@ -75,13 +76,13 @@ Status AutoIncIDBuffer::sync_request_ids(size_t length,
return Status::OK();
}
-void AutoIncIDBuffer::_prefetch_ids(size_t length) {
+Status AutoIncIDBuffer::_prefetch_ids(size_t length) {
Review Comment:
warning: method '_prefetch_ids' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/autoinc_buffer.h:64:
```diff
- Status _prefetch_ids(size_t length);
+ static Status _prefetch_ids(size_t length);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
