xiaokang commented on code in PR #30145:
URL: https://github.com/apache/doris/pull/30145#discussion_r1500147881
##########
be/src/olap/compaction.cpp:
##########
@@ -582,53 +640,54 @@ void
CompactionMixin::construct_skip_inverted_index(RowsetWriterContext& ctx) {
for (auto i = 0; i < rowset->num_segments(); i++) {
auto segment_file = rowset->segment_file_path(i);
- std::string inverted_index_src_file_path =
- InvertedIndexDescriptor::get_index_file_name(
- segment_file, index_meta->index_id(),
- index_meta->get_index_suffix());
+ io::Path segment_path(segment_file);
+ auto inverted_index_file_reader =
std::make_unique<InvertedIndexFileReader>(
+ fs, segment_path.parent_path(),
segment_path.filename(),
+
_cur_tablet_schema->get_inverted_index_storage_format());
+ bool open_idx_file_cache = false;
+ auto st =
inverted_index_file_reader->init(config::inverted_index_read_buffer_size,
+
open_idx_file_cache);
+ if (!st.ok()) {
+ LOG(WARNING) << "init index "
+ <<
inverted_index_file_reader->get_index_file_path(index_meta)
+ << " error:" << st;
+ return false;
+ }
+
bool exists = false;
- if (!fs->exists(inverted_index_src_file_path, &exists).ok()) {
- LOG(ERROR) << inverted_index_src_file_path << " fs->exists
error";
+ if (!inverted_index_file_reader->index_file_exist(index_meta,
&exists).ok()) {
+ LOG(ERROR) <<
inverted_index_file_reader->get_index_file_path(index_meta)
+ << " fs->exists error";
Review Comment:
index_file_exist error
##########
be/src/olap/compaction.cpp:
##########
@@ -582,53 +640,54 @@ void
CompactionMixin::construct_skip_inverted_index(RowsetWriterContext& ctx) {
for (auto i = 0; i < rowset->num_segments(); i++) {
auto segment_file = rowset->segment_file_path(i);
- std::string inverted_index_src_file_path =
- InvertedIndexDescriptor::get_index_file_name(
- segment_file, index_meta->index_id(),
- index_meta->get_index_suffix());
+ io::Path segment_path(segment_file);
+ auto inverted_index_file_reader =
std::make_unique<InvertedIndexFileReader>(
+ fs, segment_path.parent_path(),
segment_path.filename(),
+
_cur_tablet_schema->get_inverted_index_storage_format());
+ bool open_idx_file_cache = false;
+ auto st =
inverted_index_file_reader->init(config::inverted_index_read_buffer_size,
+
open_idx_file_cache);
+ if (!st.ok()) {
+ LOG(WARNING) << "init index "
+ <<
inverted_index_file_reader->get_index_file_path(index_meta)
+ << " error:" << st;
+ return false;
+ }
+
bool exists = false;
- if (!fs->exists(inverted_index_src_file_path, &exists).ok()) {
- LOG(ERROR) << inverted_index_src_file_path << " fs->exists
error";
+ if (!inverted_index_file_reader->index_file_exist(index_meta,
&exists).ok()) {
+ LOG(ERROR) <<
inverted_index_file_reader->get_index_file_path(index_meta)
+ << " fs->exists error";
Review Comment:
index_file_exist error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
