Nitin-Kashyap commented on code in PR #27784:
URL: https://github.com/apache/doris/pull/27784#discussion_r1477180577


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/PhysicalPlanTranslator.java:
##########
@@ -318,7 +320,8 @@ public PlanFragment 
visitPhysicalDistribute(PhysicalDistribute<? extends Plan> d
                 dataStreamSink.setOutputTupleDesc(projectionTuple);
             }
         }
-        DataPartition dataPartition = 
toDataPartition(distribute.getDistributionSpec(), validOutputIds, context);
+        DataPartition dataPartition = 
toDataPartition(distribute.getDistributionSpec(), validOutputIds, context,

Review Comment:
   yes, makes sense. I'll add it
   -- update:
   add a shuffle-function to DistributionSpecHash, so that the same is 
extensible for other hash methods (Hudi_hash, Hive-v1, Hive-v2 etc I'll add it 
in future PR)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to