github-actions[bot] commented on code in PR #30900:
URL: https://github.com/apache/doris/pull/30900#discussion_r1485638095
##########
be/src/exprs/runtime_filter_slots.h:
##########
@@ -52,7 +52,7 @@ class VRuntimeFilterSlots {
if (_is_global) {
return Status::OK();
}
- auto runtime_filter_mgr = state->runtime_filter_mgr();
+ auto runtime_filter_mgr =
state->get_query_ctx()->runtime_filter_mgr();
Review Comment:
warning: 'auto runtime_filter_mgr' can be declared as 'auto
*runtime_filter_mgr' [readability-qualified-auto]
```suggestion
auto *runtime_filter_mgr =
state->get_query_ctx()->runtime_filter_mgr();
```
##########
be/src/runtime/runtime_filter_mgr.h:
##########
@@ -73,6 +73,9 @@ class RuntimeFilterMgr {
Status get_consume_filters(const int filter_id,
std::vector<IRuntimeFilter*>& consumer_filters);
+ Status get_consume_filters_clear(const int filter_id,
Review Comment:
warning: parameter 'filter_id' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
Status get_consume_filters_clear(int filter_id,
```
##########
be/src/runtime/runtime_filter_mgr.cpp:
##########
@@ -82,6 +82,20 @@ Status RuntimeFilterMgr::get_consume_filters(const int
filter_id,
return Status::OK();
}
+Status RuntimeFilterMgr::get_consume_filters_clear(const int filter_id,
Review Comment:
warning: method 'get_consume_filters_clear' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static Status RuntimeFilterMgr::get_consume_filters_clear(const int
filter_id,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
