github-actions[bot] commented on code in PR #30829:
URL: https://github.com/apache/doris/pull/30829#discussion_r1479143497
##########
be/src/runtime/task_group/task_group.h:
##########
@@ -96,15 +96,33 @@ class TaskGroup : public
std::enable_shared_from_this<TaskGroup> {
return _memory_limit > 0;
}
- void add_query(TUniqueId query_id) { _query_id_set.insert(query_id); }
-
- void remove_query(TUniqueId query_id) { _query_id_set.erase(query_id); }
+ Status add_query(TUniqueId query_id) {
Review Comment:
warning: method 'add_query' can be made const
[readability-make-member-function-const]
```suggestion
Status add_query(TUniqueId query_id) const {
```
##########
be/src/runtime/query_context.cpp:
##########
@@ -177,4 +203,15 @@ ThreadPool* QueryContext::get_non_pipe_exec_thread_pool() {
}
}
+Status QueryContext::set_task_group(taskgroup::TaskGroupPtr& tg) {
Review Comment:
warning: method 'set_task_group' can be made static
[readability-convert-member-functions-to-static]
be/src/runtime/query_context.h:152:
```diff
- void set_task_group(taskgroup::TaskGroupPtr& tg);
+ static void set_task_group(taskgroup::TaskGroupPtr& tg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
