github-actions[bot] commented on code in PR #30729:
URL: https://github.com/apache/doris/pull/30729#discussion_r1477399034
##########
be/src/olap/iterators.h:
##########
@@ -70,10 +70,63 @@ class StorageReadOptions {
bool include_upper;
};
+ struct SplitKey {
+ std::shared_ptr<RowCursor> cursor_key;
+ std::string key;
+ std::shared_ptr<Schema> schema;
+ bool include {false};
+
+ SplitKey() = default;
+
+ SplitKey(const std::shared_ptr<RowCursor>& cursor, const std::string&
key_,
Review Comment:
warning: pass by value and use std::move [modernize-pass-by-value]
be/src/olap/iterators.h:20:
```diff
+ #include <utility>
```
```suggestion
SplitKey(const std::shared_ptr<RowCursor>& cursor, std::string key_,
```
be/src/olap/iterators.h:82:
```diff
- : cursor_key(cursor), key(key_), schema(schema_),
include(include_) {}
+ : cursor_key(cursor), key(std::move(key_)),
schema(schema_), include(include_) {}
```
##########
be/src/olap/parallel_scanner_builder.cpp:
##########
@@ -159,6 +168,175 @@ Status
ParallelScannerBuilder<ParentType>::_build_scanners_by_rowid(
return Status::OK();
}
+template <typename ParentType>
+Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
Review Comment:
warning: function '_build_scanners_by_key_range' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/parallel_scanner_builder.cpp:171:** 165 lines including
whitespace and comments (threshold 80)
```cpp
Status ParallelScannerBuilder<ParentType>::_build_scanners_by_key_range(
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
