yangzhg commented on a change in pull request #6506:
URL: https://github.com/apache/incubator-doris/pull/6506#discussion_r696238133
##########
File path: be/test/olap/tablet_schema_helper.h
##########
@@ -123,4 +123,28 @@ void set_column_value_by_type(FieldType fieldType, int
src, char* target, MemPoo
}
}
+void set_column_value_by_type(FieldType fieldType, std::string src, char*
target, MemPool* pool,
Review comment:
```suggestion
void set_column_value_by_type(FieldType fieldType, const std::string& src,
char* target, MemPool* pool,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
