github-actions[bot] commented on code in PR #30152:
URL: https://github.com/apache/doris/pull/30152#discussion_r1469434144
##########
be/src/olap/comparison_predicate.h:
##########
@@ -273,17 +257,27 @@ class ComparisonPredicateBase : public ColumnPredicate {
template <bool is_and>
__attribute__((flatten)) void _evaluate_vec_internal(const
vectorized::IColumn& column,
Review Comment:
warning: function '_evaluate_vec_internal' has cognitive complexity of 61
(threshold 50) [readability-function-cognitive-complexity]
```cpp
__attribute__((flatten)) void _evaluate_vec_internal(const
vectorized::IColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/comparison_predicate.h:259:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_can_ignore() && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:259:** +1
```cpp
if (_can_ignore() && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:260:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (is_and) {
^
```
**be/src/olap/comparison_predicate.h:261:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
for (uint16_t i = 0; i < size; i++) {
^
```
**be/src/olap/comparison_predicate.h:264:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:269:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (column.is_nullable()) {
^
```
**be/src/olap/comparison_predicate.h:277:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (nested_column.is_column_dictionary()) {
^
```
**be/src/olap/comparison_predicate.h:278:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if constexpr (std::is_same_v<T, StringRef>) {
^
```
**be/src/olap/comparison_predicate.h:284:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
do {
^
```
**be/src/olap/comparison_predicate.h:285:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
if constexpr (PT == PredicateType::EQ) {
^
```
**be/src/olap/comparison_predicate.h:286:** +6, including nesting penalty of
5, nesting level increased to 6
```cpp
if (dict_code == -2) {
^
```
**be/src/olap/comparison_predicate.h:296:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:299:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:309:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:310:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (column.is_column_dictionary()) {
^
```
**be/src/olap/comparison_predicate.h:311:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if constexpr (std::is_same_v<T, StringRef>) {
^
```
**be/src/olap/comparison_predicate.h:315:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
do {
^
```
**be/src/olap/comparison_predicate.h:316:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
if constexpr (PT == PredicateType::EQ) {
^
```
**be/src/olap/comparison_predicate.h:317:** +6, including nesting penalty of
5, nesting level increased to 6
```cpp
if (dict_code == -2) {
^
```
**be/src/olap/comparison_predicate.h:326:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:329:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:341:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_opposite) {
^
```
**be/src/olap/comparison_predicate.h:342:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
for (uint16_t i = 0; i < size; i++) {
^
```
**be/src/olap/comparison_predicate.h:347:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_can_ignore() && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:347:** +1
```cpp
if (_can_ignore() && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:349:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
for (uint16_t i = 0; i < size; i++) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
