zenoyang commented on a change in pull request #6448:
URL: https://github.com/apache/incubator-doris/pull/6448#discussion_r693541872
##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/DeleteHandler.java
##########
@@ -709,6 +745,51 @@ public void write(DataOutput out) throws IOException {
public static DeleteHandler read(DataInput in) throws IOException {
String json = Text.readString(in);
- return GsonUtils.GSON.fromJson(json, DeleteHandler.class);
+ DeleteHandler deleteHandler = GsonUtils.GSON.fromJson(json,
DeleteHandler.class);
+ deleteHandler.removeOldDeleteInfos();
+ return deleteHandler;
+ }
+
+ /**
+ * FE Master timing, or when any FE replay meta triggers DeleteInfo cleanup
+ */
+ public void removeOldDeleteInfos() {
+ Timestamp timestamp = new Timestamp();
+ removeOldDeleteInfos(timestamp);
+
Catalog.getCurrentCatalog().getEditLog().logRemoveOldDeleteInfos(timestamp);
Review comment:
It has been fixed, please review it again, thank you very much : )
@xy720
When the master or follower FE loads the image when it starts, old
deleteInfos will not clean up and generate editlog.
FE Master timing or checkpoint loading image, trigger DeleteInfo cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
