BiteTheDDDDt commented on a change in pull request #6323:
URL: https://github.com/apache/incubator-doris/pull/6323#discussion_r686455399
##########
File path: be/src/olap/storage_engine.cpp
##########
@@ -685,6 +693,8 @@ OLAPStatus StorageEngine::_start_trash_sweep(double* usage)
{
// clean unused rowset metas in OlapMeta
_clean_unused_rowset_metas();
+ _trash_sweep_lock.unlock();
Review comment:
>
>
> The method may be returned before you unlock this lock.
> you can use `src//util/mutex.h` to unlock automatically when
deconstructing.
I use unique_lock to fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
