HappenLee commented on code in PR #30082:
URL: https://github.com/apache/doris/pull/30082#discussion_r1462654801
##########
be/src/vec/sink/writer/async_result_writer.cpp:
##########
@@ -87,8 +85,20 @@ std::unique_ptr<Block>
AsyncResultWriter::_get_block_from_queue() {
}
void AsyncResultWriter::start_writer(RuntimeState* state, RuntimeProfile*
profile) {
+ // Should set to false here, to
+ _writer_thread_closed = false;
+ // This is a async thread, should lock the task ctx, to make sure
runtimestate and profile
+ // not constructed before the thread exit.
Review Comment:
destructed ？or constructed？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
