github-actions[bot] commented on code in PR #30152:
URL: https://github.com/apache/doris/pull/30152#discussion_r1458751417
##########
be/src/olap/column_predicate.h:
##########
@@ -19,13 +19,15 @@
#include <roaring/roaring.hh>
Review Comment:
warning: 'roaring/roaring.hh' file not found [clang-diagnostic-error]
```cpp
#include <roaring/roaring.hh>
^
```
##########
be/src/olap/like_column_predicate.cpp:
##########
@@ -51,8 +51,8 @@ void LikeColumnPredicate<T>::evaluate_and_vec(const
vectorized::IColumn& column,
}
template <PrimitiveType T>
-uint16_t LikeColumnPredicate<T>::evaluate(const vectorized::IColumn& column,
uint16_t* sel,
- uint16_t size) const {
+uint16_t LikeColumnPredicate<T>::_evaluate_inner(const vectorized::IColumn&
column, uint16_t* sel,
Review Comment:
warning: function '_evaluate_inner' exceeds recommended size/complexity
thresholds [readability-function-size]
```cpp
uint16_t LikeColumnPredicate<T>::_evaluate_inner(const vectorized::IColumn&
column, uint16_t* sel,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/like_column_predicate.cpp:53:** 102 lines including whitespace
and comments (threshold 80)
```cpp
uint16_t LikeColumnPredicate<T>::_evaluate_inner(const vectorized::IColumn&
column, uint16_t* sel,
^
```
</details>
##########
be/src/olap/comparison_predicate.h:
##########
@@ -274,16 +258,16 @@ class ComparisonPredicateBase : public ColumnPredicate {
__attribute__((flatten)) void _evaluate_vec_internal(const
vectorized::IColumn& column,
Review Comment:
warning: function '_evaluate_vec_internal' has cognitive complexity of 55
(threshold 50) [readability-function-cognitive-complexity]
```cpp
__attribute__((flatten)) void _evaluate_vec_internal(const
vectorized::IColumn& column,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/comparison_predicate.h:259:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (column.is_nullable()) {
^
```
**be/src/olap/comparison_predicate.h:267:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (nested_column.is_column_dictionary()) {
^
```
**be/src/olap/comparison_predicate.h:268:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if constexpr (std::is_same_v<T, StringRef>) {
^
```
**be/src/olap/comparison_predicate.h:274:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
do {
^
```
**be/src/olap/comparison_predicate.h:275:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
if constexpr (PT == PredicateType::EQ) {
^
```
**be/src/olap/comparison_predicate.h:276:** +6, including nesting penalty of
5, nesting level increased to 6
```cpp
if (dict_code == -2) {
^
```
**be/src/olap/comparison_predicate.h:286:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:289:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:299:** +1, nesting level increased to 1
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:300:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (column.is_column_dictionary()) {
^
```
**be/src/olap/comparison_predicate.h:301:** +3, including nesting penalty of
2, nesting level increased to 3
```cpp
if constexpr (std::is_same_v<T, StringRef>) {
^
```
**be/src/olap/comparison_predicate.h:305:** +4, including nesting penalty of
3, nesting level increased to 4
```cpp
do {
^
```
**be/src/olap/comparison_predicate.h:306:** +5, including nesting penalty of
4, nesting level increased to 5
```cpp
if constexpr (PT == PredicateType::EQ) {
^
```
**be/src/olap/comparison_predicate.h:307:** +6, including nesting penalty of
5, nesting level increased to 6
```cpp
if (dict_code == -2) {
^
```
**be/src/olap/comparison_predicate.h:316:** +1, nesting level increased to 3
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:319:** +1, nesting level increased to 2
```cpp
} else {
^
```
**be/src/olap/comparison_predicate.h:331:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_opposite) {
^
```
**be/src/olap/comparison_predicate.h:332:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
for (uint16_t i = 0; i < size; i++) {
^
```
**be/src/olap/comparison_predicate.h:338:** +1, including nesting penalty of
0, nesting level increased to 1
```cpp
if (_can_ignore() && is_and && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:338:** +1
```cpp
if (_can_ignore() && is_and && !_has_calculate_filter) {
^
```
**be/src/olap/comparison_predicate.h:340:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
for (uint16_t i = 0; i < size; i++) {
^
```
**be/src/olap/comparison_predicate.h:345:** +2, including nesting penalty of
1, nesting level increased to 2
```cpp
if (_can_ignore()) {
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
