github-actions[bot] commented on code in PR #30082:
URL: https://github.com/apache/doris/pull/30082#discussion_r1455764241
##########
be/src/pipeline/task_scheduler.cpp:
##########
@@ -343,39 +349,20 @@ void TaskScheduler::_do_work(size_t index) {
}
}
-void TaskScheduler::_try_close_task(PipelineTask* task, PipelineTaskState
state,
- Status exec_status) {
+void TaskScheduler::_close_task(PipelineTask* task, PipelineTaskState state,
Status exec_status) {
Review Comment:
warning: method '_close_task' can be made static
[readability-convert-member-functions-to-static]
be/src/pipeline/task_scheduler.h:106:
```diff
- void _close_task(PipelineTask* task, PipelineTaskState state,
+ static void _close_task(PipelineTask* task, PipelineTaskState state,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
