JNSimba commented on code in PR #298:
URL:
https://github.com/apache/doris-flink-connector/pull/298#discussion_r1455112021
##########
flink-doris-connector/src/main/java/org/apache/doris/flink/sink/writer/serializer/jsondebezium/JsonDebeziumSchemaChangeImplV2.java:
##########
@@ -337,6 +337,9 @@ public String buildDorisTypeName(JsonNode column) {
String dorisTypeName;
switch (sourceConnector) {
case MYSQL:
+ if (sourceTypeName.equals("DATETIME") ||
sourceTypeName.equals("TIMESTAMP")) {
+ length = 20 + length;
+ }
dorisTypeName = MysqlType.toDorisType(sourceTypeName, length,
scale);
Review Comment:
Can it be added directly to this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
