github-actions[bot] commented on PR #30054:
URL: https://github.com/apache/doris/pull/30054#issuecomment-1895300431
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/7552813271";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In build.sh line 567:
MAKE_PROGRAM="$(which "${BUILD_SYSTEM}")"
^---^ SC2230 (info): 'which' is non-standard. Use
builtin 'command -v' instead.
In gensrc/script/gen_build_version.sh line 211:
if [ -f /etc/os-release ]; then
^--------------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
Did you mean:
if [[ -f /etc/os-release ]]; then
In gensrc/script/gen_build_version.sh line 212:
build_os_version=$(cat /etc/os-release | head -n2 | tr '\n' ' ')
^-------------^ SC2002 (style): Useless cat.
Consider 'cmd < file | ..' or 'cmd file | ..' instead.
In gensrc/script/gen_build_version.sh line 232:
build_initiator="${user}@${hostname}"
^-----^ SC2154 (warning): user is referenced but not
assigned.
For more information:
https://www.shellcheck.net/wiki/SC2154 -- user is referenced but not
assign...
https://www.shellcheck.net/wiki/SC2230 -- 'which' is non-standard. Use
buil...
https://www.shellcheck.net/wiki/SC2002 -- Useless cat. Consider 'cmd <
file...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- gensrc/script/gen_build_version.sh.orig
+++ gensrc/script/gen_build_version.sh
@@ -50,9 +50,7 @@
fi
if [[ -z "${DORIS_TEST_BINARY_DIR}" ]]; then
- if [[ -e
"${DORIS_HOME}/fe/fe-core/target/generated-sources/build/org/apache/doris/common/Version.java"
&& -e \
- "${DORIS_HOME}/gensrc/build/gen_cpp/version.h" && -e \
- "${DORIS_HOME}/gensrc/build/gen_cpp/cloud_version.h" ]]; then
+ if [[ -e
"${DORIS_HOME}/fe/fe-core/target/generated-sources/build/org/apache/doris/common/Version.java"
&& -e "${DORIS_HOME}/gensrc/build/gen_cpp/version.h" && -e
"${DORIS_HOME}/gensrc/build/gen_cpp/cloud_version.h" ]]; then
exit
fi
fi
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
