github-actions[bot] commented on code in PR #29115:
URL: https://github.com/apache/doris/pull/29115#discussion_r1452442893
##########
be/src/vec/sink/load_stream_stub.cpp:
##########
@@ -332,8 +338,23 @@ Status LoadStreamStub::close_wait(int64_t timeout_ms) {
return Status::OK();
}
+void LoadStreamStub::cancel(Status reason) {
Review Comment:
warning: method 'cancel' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/sink/load_stream_stub.h:156:
```diff
- void cancel(Status reason);
+ static void cancel(Status reason);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
