github-actions[bot] commented on code in PR #29849:
URL: https://github.com/apache/doris/pull/29849#discussion_r1448387264
##########
be/src/olap/tablet_meta.cpp:
##########
@@ -400,15 +401,15 @@ std::string TabletMeta::construct_header_file_path(const
string& schema_hash_pat
return header_name_stream.str();
}
-Status TabletMeta::save_as_json(const string& file_path, DataDir* dir) {
+Status TabletMeta::save_as_json(const string& file_path) {
Review Comment:
warning: method 'save_as_json' can be made static
[readability-convert-member-functions-to-static]
be/src/olap/tablet_meta.h:121:
```diff
- Status save_as_json(const string& file_path);
+ static Status save_as_json(const string& file_path);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
