yiguolei commented on code in PR #29466:
URL: https://github.com/apache/doris/pull/29466#discussion_r1440181949
##########
be/src/vec/sink/vresult_file_sink.cpp:
##########
@@ -110,44 +113,54 @@ Status VResultFileSink::open(RuntimeState* state) {
return AsyncWriterSink::open(state);
}
-Status VResultFileSink::close(RuntimeState* state, Status exec_status) {
+Status VResultFileSink::try_close(RuntimeState* rs, Status exec_status) {
Review Comment:
这种地方不要重命名， 现在已经是state了，就保持叫state。
rs 在数据库里可能是resultset
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
