github-actions[bot] commented on code in PR #29386:
URL: https://github.com/apache/doris/pull/29386#discussion_r1439138775
##########
be/src/olap/schema_change.cpp:
##########
@@ -1035,7 +991,10 @@ Status SchemaChangeHandler::_get_versions_to_be_changed(
return Status::OK();
}
-Status SchemaChangeHandler::_convert_historical_rowsets(const
SchemaChangeParams& sc_params) {
+// The `real_alter_version` parameter indicates that the version of
[0-real_alter_version] is
+// converted from a base tablet, only used for the mow table now.
+Status SchemaChangeHandler::_convert_historical_rowsets(const
SchemaChangeParams& sc_params,
Review Comment:
warning: function '_convert_historical_rowsets' exceeds recommended
size/complexity thresholds [readability-function-size]
```cpp
Status SchemaChangeHandler::_convert_historical_rowsets(const
SchemaChangeParams& sc_params,
^
```
<details>
<summary>Additional context</summary>
**be/src/olap/schema_change.cpp:995:** 133 lines including whitespace and
comments (threshold 80)
```cpp
Status SchemaChangeHandler::_convert_historical_rowsets(const
SchemaChangeParams& sc_params,
^
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
