[GitHub] [incubator-doris] morningman commented on a change in pull request #6023: Support alter default bucket_num of table

[GitBox]

morningman commented on a change in pull request #6023:
URL: https://github.com/apache/incubator-doris/pull/6023#discussion_r659902634



##########
File path: fe/fe-core/src/main/java/org/apache/doris/catalog/Catalog.java
##########
@@ -5545,6 +5547,74 @@ public void replayModifyTableProperty(short opCode, 
ModifyTablePropertyOperation
         }
     }
 
+    public void modifyDefaultDistributionBucketNum(Database db, OlapTable 
olapTable, ModifyDistributionClause modifyDistributionClause) throws 
DdlException {
+        olapTable.writeLock();

Review comment:
       The pattern of lock should be:
   ```
   olapTable.writeLock();
   try {
      ......
   } finally {
       olapTable.writeUnlock();
   }




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org