LuGuangming commented on code in PR #29063:
URL: https://github.com/apache/doris/pull/29063#discussion_r1438089589
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/PropertyConverter.java:
##########
@@ -267,6 +267,10 @@ private static void setS3FsAccess(Map<String, String>
s3Properties, Map<String,
String credentialsProviders = s3Properties
.getOrDefault(S3Properties.CREDENTIALS_PROVIDER,
defaultProviderList);
s3Properties.put(Constants.AWS_CREDENTIALS_PROVIDER,
credentialsProviders);
+ if (properties.get(S3Properties.Env.ENDPOINT) != null
+ &&
properties.get(S3Properties.Env.ENDPOINT).toLowerCase(Locale.ROOT).startsWith("obs"))
{
+ s3Properties.put("fs.s3a.connection.ssl.enabled", "false");
Review Comment:
OK, The previous is compatible with s3 modification, and then directly used
OBS properties
"fs.obs.access.key" = "xx",
"fs.obs.secret.key" = "xx",
"fs.obs.endpoint" = "xx"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
