github-actions[bot] commented on code in PR #29297:
URL: https://github.com/apache/doris/pull/29297#discussion_r1438080604
##########
be/src/vec/columns/column_struct.cpp:
##########
@@ -185,6 +185,27 @@ const char*
ColumnStruct::deserialize_and_insert_from_arena(const char* pos) {
return pos;
}
+int ColumnStruct::compare_at(size_t n, size_t m, const IColumn& rhs_,
Review Comment:
warning: method 'compare_at' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_struct.h:160:
```diff
- int compare_at(size_t n, size_t m, const IColumn& rhs_, int
nan_direction_hint) const override;
+ static int compare_at(size_t n, size_t m, const IColumn& rhs_, int
nan_direction_hint) override;
```
be/src/vec/columns/column_struct.cpp:188:
```diff
- int nan_direction_hint) const {
+ int nan_direction_hint) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
