englefly commented on code in PR #29184:
URL: https://github.com/apache/doris/pull/29184#discussion_r1437986297
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/stats/FilterEstimation.java:
##########
@@ -117,6 +118,11 @@ public Statistics visitCompoundPredicate(CompoundPredicate
predicate, Estimation
colBuilder.setMinValue(union.getLow()).setMinExpr(union.getLowExpr())
.setMaxValue(union.getHigh()).setMaxExpr(union.getHighExpr())
.setNdv(union.getDistinctValues());
+ if (!(leftExpr instanceof IsNull || rightExpr instanceof
IsNull)) {
+ colBuilder.setNumNulls(0);
Review Comment:
A is null or A is not null
=>A.numNulls = 0
this is not true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
