yiguolei commented on code in PR #29265:
URL: https://github.com/apache/doris/pull/29265#discussion_r1437761799
##########
be/src/vec/core/field.cpp:
##########
@@ -169,19 +169,19 @@ bool dec_less_or_equal(T x, T y, UInt32 x_scale, UInt32
y_scale) {
DECLARE_DECIMAL_COMPARISON(Decimal32)
DECLARE_DECIMAL_COMPARISON(Decimal64)
-DECLARE_DECIMAL_COMPARISON(Decimal128)
+DECLARE_DECIMAL_COMPARISON(Decimal128V2)
DECLARE_DECIMAL_COMPARISON(Decimal256)
template <>
-bool decimal_equal(Decimal128I x, Decimal128I y, UInt32 xs, UInt32 ys) {
- return dec_equal(Decimal128(x.value), Decimal128(y.value), xs, ys);
+bool decimal_equal(Decimal128V3 x, Decimal128V3 y, UInt32 xs, UInt32 ys) {
+ return dec_equal(Decimal128V2(x.value), Decimal128V2(y.value), xs, ys);
Review Comment:
These code is very suspicious?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
