mymeiyi commented on code in PR #29178:
URL: https://github.com/apache/doris/pull/29178#discussion_r1437396699
##########
be/src/runtime/group_commit_mgr.cpp:
##########
@@ -43,10 +44,22 @@ namespace doris {
Status LoadBlockQueue::add_block(std::shared_ptr<vectorized::Block> block,
bool write_wal) {
std::unique_lock l(mutex);
RETURN_IF_ERROR(status);
+ auto start = std::chrono::steady_clock::now();
while (_all_block_queues_bytes->load(std::memory_order_relaxed) >
- config::group_commit_max_queue_size) {
+ config::group_commit_queue_max_mem_limit) {
+ if (!status.ok()) {
+ _cancel_without_lock(status);
+ return status;
+ }
_put_cond.wait_for(
l,
std::chrono::milliseconds(LoadBlockQueue::MAX_BLOCK_QUEUE_ADD_WAIT_TIME));
+ auto duration = std::chrono::duration_cast<std::chrono::milliseconds>(
+ std::chrono::steady_clock::now() - start);
+ if (duration.count() > LoadBlockQueue::WAL_MEM_BACK_PRESSURE_TIME_OUT)
{
+ return Status::TimedOut(
+ "Wal memory back pressure wait too much time! Load block
queue txn id: {}",
+ txn_id);
Review Comment:
print label is better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
