github-actions[bot] commented on code in PR #29185:
URL: https://github.com/apache/doris/pull/29185#discussion_r1437063851
##########
be/src/olap/tablet.h:
##########
@@ -562,6 +563,9 @@ class Tablet final : public BaseTablet {
std::unique_ptr<segment_v2::ColumnIterator>* column_iterator,
OlapReaderStatistics* stats);
+ void set_variant_config(VariantConfig binlog_config);
+ const VariantConfig& variant_config() const;
+
Review Comment:
warning: parameter 'rowset_id' is const-qualified in the function
declaration; const-qualification of parameters only has an effect in function
definitions [readability-avoid-const-params-in-decls]
```suggestion
bool _contains_rowset(RowsetId rowset_id);
```
##########
be/src/olap/tablet_meta.h:
##########
@@ -251,6 +254,11 @@ class TabletMeta {
return _time_series_compaction_time_threshold_seconds;
}
+ const VariantConfig& variant_config() const { return _variant_config; }
+ void set_variant_config(VariantConfig variant_config) {
+ _variant_config = std::move(variant_config);
+ }
+
private:
Status _save_meta(DataDir* data_dir);
Review Comment:
warning: redundant access specifier has the same accessibility as the
previous access specifier [readability-redundant-access-specifiers]
```suggestion
```
<details>
<summary>Additional context</summary>
**be/src/olap/tablet_meta.h:256:** previously declared here
```cpp
private:
^
```
</details>
##########
be/src/vec/columns/column_object.cpp:
##########
@@ -583,6 +587,11 @@ ColumnObject::ColumnObject(bool is_nullable_, bool
create_root_)
}
}
+ColumnObject::ColumnObject(VariantConfig variant_config)
+ : is_nullable(true), num_rows(0), config(std::move(variant_config)) {
+ subcolumns.create_root(Subcolumn(0, is_nullable, true /*root*/));
+}
Review Comment:
warning: method 'check_consistency' can be made static
[readability-convert-member-functions-to-static]
be/src/vec/columns/column_object.h:234:
```diff
- void check_consistency() const;
+ static void check_consistency() ;
```
```suggestion
void ColumnObject::check_consistency() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
