github-actions[bot] commented on code in PR #28788:
URL: https://github.com/apache/doris/pull/28788#discussion_r1437028557
##########
be/src/exprs/bloom_filter_func.h:
##########
@@ -392,9 +403,9 @@ struct StringFindOp : CommonFindOp<StringRef> {
// We do not need to judge whether data is empty, because null will not appear
// when filer used by the storage engine
struct FixedStringFindOp : public StringFindOp {
- uint16_t find_batch_olap_engine(const BloomFilterAdaptor& bloom_filter,
const char* data,
- const uint8* nullmap, uint16_t* offsets,
int number,
- const bool is_parse_column) {
+ static uint16_t find_batch_olap_engine(const BloomFilterAdaptor&
bloom_filter, const char* data,
+ const uint8* nullmap, uint16_t*
offsets, int number,
Review Comment:
warning: pointer parameter 'offsets' can be pointer to const
[readability-non-const-parameter]
```suggestion
const uint8* nullmap, const
uint16_t* offsets, int number,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
