seawinde commented on code in PR #29132: URL: https://github.com/apache/doris/pull/29132#discussion_r1436961560
########## fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/HyperGraphComparator.java: ########## @@ -108,16 +109,22 @@ private ComparisonResult isLogicCompatible() { private ComparisonResult buildComparisonRes() { ComparisonResult.Builder builder = new ComparisonResult.Builder(); for (Entry<Edge, List<? extends Expression>> e : pullUpQueryExprWithEdge.entrySet()) { - if (!e.getValue().isEmpty() && !canPullUp(e.getKey())) { + List<? extends Expression> rawFilter = e.getValue().stream() + .filter(expr -> !expr.isInferred()) Review Comment: this should use method `org.apache.doris.nereids.util.ExpressionUtils#isInferred` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org