github-actions[bot] commented on code in PR #29124:
URL: https://github.com/apache/doris/pull/29124#discussion_r1436766636
##########
be/src/vec/exec/scan/vscanner.cpp:
##########
@@ -58,9 +60,30 @@ Status VScanner::prepare(RuntimeState* state, const
VExprContextSPtrs& conjuncts
}
}
+ const auto& projections = _parent ? _parent->_projections :
_local_state->_projections;
+ if (!projections.empty()) {
+ _projections.resize(projections.size());
+ for (size_t i = 0; i != projections.size(); ++i) {
+ RETURN_IF_ERROR(projections[i]->clone(state, _projections[i]));
+ }
+ }
+
return Status::OK();
}
+Status VScanner::get_block_after_projects(RuntimeState* state,
vectorized::Block* block,
+ bool* eos) {
+ auto& row_descriptor =
+ _parent ? _parent->_row_descriptor :
_local_state->_parent->row_descriptor();
+ if (_output_row_descriptor) {
+
_origin_block.clear_column_data(row_descriptor.num_materialized_slots());
+ auto status = get_block(state, &_origin_block, eos);
+ if (UNLIKELY(!status.ok())) return status;
Review Comment:
warning: statement should be inside braces
[readability-braces-around-statements]
```suggestion
if (UNLIKELY(!status.ok())) { return status;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
