yiguolei commented on code in PR #29116:
URL: https://github.com/apache/doris/pull/29116#discussion_r1436712725
##########
be/src/runtime/fragment_mgr.cpp:
##########
@@ -1567,4 +1568,26 @@ void
FragmentMgr::_setup_shared_hashtable_for_broadcast_join(const TPipelineFrag
}
}
+void FragmentMgr::get_runtime_query_info(std::vector<WorkloadQueryInfo>*
query_info_list) {
Review Comment:
不要加这个类，直接用QueryContext， 现在这种做法会导致，每次我们要增加一个统计指标，需要改2个地方。
我么在query context，每个metric name 都要一个对应的函数，比如 query_exec_time(),
query_cpu_time(), query_scan_bytes().
workload group 只需要拿到query context 的shared ptr 就可以
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
