github-actions[bot] commented on code in PR #29056:
URL: https://github.com/apache/doris/pull/29056#discussion_r1436340166
##########
be/test/olap/rowset/segment_v2/binary_dict_page_test.cpp:
##########
@@ -221,7 +224,62 @@ class BinaryDictPageTest : public testing::Test {
<< ", line number:" <<
page_start_ids[slice_index] + pos + 1;
}
}
-};
+
+ void test_automatically_fallback() {
Review Comment:
warning: method 'test_automatically_fallback' can be made static
[readability-convert-member-functions-to-static]
```suggestion
static void test_automatically_fallback() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
