github-actions[bot] commented on code in PR #28926:
URL: https://github.com/apache/doris/pull/28926#discussion_r1436179208


##########
be/src/vec/exec/scan/vscan_node.cpp:
##########
@@ -318,8 +322,8 @@ Status VScanNode::_init_profile() {
     return Status::OK();
 }
 
-Status VScanNode::_start_scanners(const std::list<VScannerSPtr>& scanners,
-                                  const int query_parallel_instance_num) {
+void VScanNode::_start_scanners(const 
std::list<std::shared_ptr<ScannerDelegate>>& scanners,

Review Comment:
   warning: method '_start_scanners' can be made const 
[readability-make-member-function-const]
   
   be/src/vec/exec/scan/vscan_node.cpp:325:
   ```diff
   -                                 const int query_parallel_instance_num) {
   +                                 const int query_parallel_instance_num) 
const {
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to