bobhan1 commented on code in PR #28968:
URL: https://github.com/apache/doris/pull/28968#discussion_r1436052330


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/DeleteStmt.java:
##########
@@ -157,7 +157,7 @@ private void constructInsertStmt() throws AnalysisException 
{
                 expr = new BoolLiteral(true);
             } else if (column.isKey()) {
                 expr = new SlotRef(targetTableRef.getAliasAsName(), 
column.getName());
-            } else if (!isMow && !column.isVisible()) {
+            } else if (!isMow && (!column.isVisible() || 
(!column.isAllowNull() && !column.hasDefaultValue()))) {

Review Comment:
   This condition is accidentally deleted in 
https://github.com/apache/doris/pull/26776 due to not considering mor table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to