morrySnow commented on code in PR #28982:
URL: https://github.com/apache/doris/pull/28982#discussion_r1436037750
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/parser/LogicalPlanBuilder.java:
##########
@@ -2438,18 +2438,27 @@ public IndexDefinition visitIndexDef(IndexDefContext
ctx) {
@Override
public List<PartitionDefinition> visitPartitionsDef(PartitionsDefContext
ctx) {
return ctx.partitions.stream()
- .map(p -> ((PartitionDefinition)
visit(p)).withProperties(visitPropertyClause(p.properties)))
- .collect(Collectors.toList());
+ .map(p -> ((PartitionDefinition)
visit(p))).collect(Collectors.toList());
+ }
+
+ @Override
+ public PartitionDefinition
visitPartitionDef(DorisParser.PartitionDefContext ctx) {
+ PartitionDefinition partitionDefinition = (PartitionDefinition)
visit(ctx.getChild(0));
+ if (ctx.partitionProperties != null) {
+
partitionDefinition.withProperties(visitPropertyItemList(ctx.partitionProperties));
+ }
+ return partitionDefinition;
}
@Override
public PartitionDefinition
visitLessThanPartitionDef(LessThanPartitionDefContext ctx) {
String partitionName = ctx.partitionName.getText();
if (ctx.MAXVALUE() == null) {
List<Expression> lessThanValues =
visitConstantSeq(ctx.constantSeq());
- return new LessThanPartition(partitionName, lessThanValues);
+ return new LessThanPartition(ctx.ifNotExists != null,
partitionName, lessThanValues);
Review Comment:
`ctx.EXISTS() != null` is enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
